Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add systemd restart override #483

Merged
merged 2 commits into from
May 4, 2019
Merged

add systemd restart override #483

merged 2 commits into from
May 4, 2019
+42 −8

Conversation

BenTheElder
Copy link
Member

In case the service exits, we want to ensure that it restarts.

The ubuntu package currently has (appears to be very similar to upstream):

[Unit]
Description=containerd container runtime
Documentation=https://containerd.io
After=network.target

[Service]
ExecStartPre=-/sbin/modprobe overlay
ExecStart=/usr/bin/containerd

Delegate=yes
KillMode=process
# Having non-zero Limit*s causes performance problems due to accounting overhead
# in the kernel. We recommend using cgroups to do container-local accounting.
LimitNPROC=infinity
LimitCORE=infinity
LimitNOFILE=infinity
# Comment TasksMax if your systemd version does not supports it.
# Only systemd 226 and above support this version.
TasksMax=infinity

[Install]
WantedBy=multi-user.target

cc @Random-Liu, perhaps something else to push upstream at some point ...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 4, 2019
@k8s-ci-robot k8s-ci-robot requested review from munnerz and neolit123 May 4, 2019 08:57
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 4, 2019
@BenTheElder BenTheElder added this to the 0.3 milestone May 4, 2019
neolit123
neolit123 reviewed May 4, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 4, 2019
aojea
aojea reviewed May 4, 2019
View reviewed changes
images/base/10-restart.conf
Restart=always
RestartSec=1

# disable rate limiting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why disabling the rate limiting?
I experienced problems because a service is restarting continuously but the check wasn´t able to detect it down , can this happen to us?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It starts in under a second, the default rate limit of 5 in 10s doesn't seem useful in the context of kind, if we can determine a better one for kind we should do that.

We have no checks for this, instead we're observing if the workloads are up.

kubelet and containerd are our only services.

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2019
@BenTheElder
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 89d63f8 into kubernetes-sigs:master May 4, 2019
@BenTheElder BenTheElder deleted the restart-override branch May 4, 2019 18:11
stg-0 pushed a commit to stg-0/kind that referenced this pull request Mar 4, 2024
@iamjanr
Update instllation and quick start guide -cluster create- (kubernetes…
26a27b0 
…-sigs#483)

* Update installation.adoc with latest create cluster gcp

* Update quick-start-guide.adoc with latest create cluster gcp

* Update quick-start-guide.adoc with latest create cluster aws unmanaged

* Update quick-start-guide.adoc with latest create cluster eks/aks

* Change -Enabling workload cluster's to Enabling workload clusters in order to avoid doc bad view

* Change -Enabling workload cluster's to Enabling workload clusters in order to avoid doc bad view -installation-

* Do EN doc update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@neolit123 neolit123 neolit123 left review comments

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @k8s-ci-robot @neolit123 @aojea